feat: prevent deletion of seeded entity schemas#21
Draft
themusicman wants to merge 3 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteEntitythat rejects attempts to delete the schema of seeded entity types (people, tasks, notes, links, interests, skills)Seeds.seeded_type?/1helper to check if a type is seededDetailed Changes
Backend
Brain.Seeds— Newseeded_type?/1function that checks membership againstentity_types/0DeleteEntity— Pre-delete guard that blocks schema-targeted deletions (__schema__,schema, type name,<type>.json) for seeded types while still allowing normal entity deletions within those typesBrain.Helpers— New:protected_entity_typeerror formatting with the offending type nameTests
SeedsTest—seeded_type?/1returns true for all 6 seeded types, false for custom types and nilBrainActionsTest— Rejection of seeded schema deletion, successful entity deletion within seeded types, successful deletion in custom typesTest plan
seeded_type?/1returns true for all seeded typesseeded_type?/1returns false for non-seeded values